Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Code for ds/org.eclipse.pde.ds.tests #1647

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Clean Code for ds/org.eclipse.pde.ds.tests #1647

merged 2 commits into from
Mar 7, 2025

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Mar 6, 2025 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From f0780bb6f62f52f7309536d3520f04c76a5a7124 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Fri, 7 Mar 2025 02:53:06 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF
index 816084e2c0..c34ac0c470 100644
--- a/ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.ds.tests
-Bundle-Version: 1.3.300.qualifier
+Bundle-Version: 1.3.400.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ds.tests.Activator
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.pde.core;bundle-version="[3.3.0,4.0.0)",
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

Test Results

   285 files  ±0     285 suites  ±0   50m 44s ⏱️ + 3m 43s
 3 608 tests ±0   3 532 ✅ +1   76 💤 ±0  0 ❌  - 1 
11 016 runs  ±0  10 785 ✅ +1  231 💤 ±0  0 ❌  - 1 

Results for commit 1039051. ± Comparison against base commit 4e00417.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/ds/org.eclipse.pde.ds.tests branch from 0ac2cd5 to 7590ef0 Compare March 6, 2025 13:40
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.tests branch from 7590ef0 to 004d97e Compare March 7, 2025 02:45
@laeubi laeubi merged commit 95a8287 into master Mar 7, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/ds/org.eclipse.pde.ds.tests branch March 7, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eclipse-pde-bot @laeubi